Fixes #39378 - replace snapshot tests for taskaction component#822
Open
andreilakatos wants to merge 1 commit into
Open
Fixes #39378 - replace snapshot tests for taskaction component#822andreilakatos wants to merge 1 commit into
andreilakatos wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #39378 by replacing Jest snapshot-based tests for the TaskActions action creators with explicit assertion-based tests, improving clarity around dispatched actions/toasts and removing the associated snapshot file.
Changes:
- Replaced
testActionSnapshotWithFixturessnapshot tests with explicitdispatch/API.postassertions for cancel/resume/force-cancel/unlock flows. - Added direct expectations for action types and toast payloads for both success and failure paths.
- Removed the now-unused Jest snapshot file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webpack/ForemanTasks/Components/TaskActions/TaskAction.test.js | Rewrites action tests to assert dispatch sequences, toast payloads, and API endpoints instead of relying on snapshots. |
| webpack/ForemanTasks/Components/TaskActions/snapshots/TaskAction.test.js.snap | Deletes obsolete snapshots after moving away from snapshot-based testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.