Fixes #39384 - replace snapshot test for taskdashboard component#823
Open
andreilakatos wants to merge 1 commit into
Open
Fixes #39384 - replace snapshot test for taskdashboard component#823andreilakatos wants to merge 1 commit into
andreilakatos wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Replaces the existing snapshot-based test for the TasksDashboard React component with explicit assertions using React Testing Library, improving test signal and reducing snapshot churn.
Changes:
- Migrated
TasksDashboardtest fromtestComponentSnapshotsWithFixturessnapshot testing to RTL-based DOM/behavior assertions. - Added targeted mocks (URL query helper + donut chart) to keep the test focused and stable.
- Removed the obsolete Jest snapshot file for
TasksDashboard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webpack/ForemanTasks/Components/TasksDashboard/tests/TasksDashboard.test.js | Replaces snapshot coverage with RTL assertions for rendering and lifecycle-triggered fetch behavior. |
| webpack/ForemanTasks/Components/TasksDashboard/tests/snapshots/TasksDashboard.test.js.snap | Removes snapshot output no longer used by the updated test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.