Fixes #39387 - replace snapshot test for taskdashboardselectors#826
Open
andreilakatos wants to merge 1 commit into
Open
Fixes #39387 - replace snapshot test for taskdashboardselectors#826andreilakatos wants to merge 1 commit into
andreilakatos wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces a Jest snapshot-based selector test for the Tasks Dashboard with explicit assertions, making the selector behavior easier to understand and less brittle over time.
Changes:
- Replaced
testSelectorsSnapshotWithFixturessnapshot coverage with explicitit(...)unit tests for each selector. - Added explicit expectations for default selector behavior when the Redux state is empty.
- Removed the obsolete snapshot output for
TasksDashboardSelectorstests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webpack/ForemanTasks/Components/TasksDashboard/tests/TasksDashboardSelectors.test.js | Rewrites selector tests from snapshot fixtures to explicit assertions (including empty-state defaults). |
| webpack/ForemanTasks/Components/TasksDashboard/tests/snapshots/TasksDashboardSelectors.test.js.snap | Removes snapshot expectations that are no longer used after switching to explicit assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+106
to
+108
| it('should select query', () => { | ||
| expect(selectQuery(state)).toBe('some-query'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.