Fixes #39357 - deprecate LineChart component that uses PF3 LineChart#11001
Open
andreilakatos wants to merge 1 commit into
Open
Fixes #39357 - deprecate LineChart component that uses PF3 LineChart#11001andreilakatos wants to merge 1 commit into
andreilakatos wants to merge 1 commit into
Conversation
andreilakatos
force-pushed
the
linechart-deprecation
branch
from
df777bf to
404d809
Compare
andreilakatos
force-pushed
the
linechart-deprecation
branch
from
8a707d9 to
ec18ce3
Compare
adamruzicka
reviewed
May 26, 2026
andreilakatos
force-pushed
the
linechart-deprecation
branch
from
ec18ce3 to
39c2ad0
Compare
Lukshio
suggested changes
May 29, 2026
andreilakatos
force-pushed
the
linechart-deprecation
branch
from
39c2ad0 to
cb9d7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a developer-facing deprecation warning for the PF3
patternfly-reactLineChartwrapper (common/charts/LineChart). The warning is emitted once per mount (same pattern ascommon/table/components/Table), points consumers toward@patternfly/react-charts, and states planned removal in Foreman 3.21.No user-visible UI changes; behaviour of the chart is unchanged.
How to test
Prerequisites
LineChartcomponent (plugin or core mount point that usesforeman-react/componentRegistrynameLineChart).NODE_ENVnotproductionso the warning appears).Scenarios
LineChart(if unsure, search mounts /mount_react_component/ plugin usage for theLineChartcomponent name).DEPRECATION WARNING: you are using deprecated common/charts/LineChart ... will be removed in Foreman 3.21npm testwith the LineChart test path to ensure snapshots still pass.