Fixes #39383 - add no-magic-numbers js lint rule#11008
Open
MariaAga wants to merge 1 commit into
Open
Conversation
MariaAga
force-pushed
the
lint-magic-numbers
branch
from
14baf3e to
0239ad7
Compare
Member
Author
|
Thanks, updated to have export const MS_PER_SECOND = 1000;
export const PERCENT_MULTIPLIER = 100;
export const HTTP_STATUS_CODES = { ...Also changed the rule to be an error and not a warning so the git action will fail when magic numbers are used (for easier reviewing experience) |
MariaAga
force-pushed
the
lint-magic-numbers
branch
from
0239ad7 to
ca04d1d
Compare
MariaAga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add no-magic-numbers lint rule and fix violations
Adds
no-magic-numbersas awarnrule to ESLint config with common values ignored (0-8, pagination sizes, HTTP status codes, etc.).Extracts magic numbers into named constants across ~20 files (e.g.
MS_PER_SECOND,BYTES_PER_KB,TAB_WEIGHT_*, luminance coefficients).Also adds
unameto spellcheck skipWords.This PR was created with AI assistance.