Improve the description/help text... - #786
Merged
stejskalleos merged 1 commit intoAug 31, 2026
Merged
Conversation
lzap
suggested changes
Aug 26, 2026
| help: Name of the PAM service to use for IPA authentication | ||
| foreman_log_level: | ||
| help: Log level for Foreman. Defaults to the global log level. | ||
| help: Default log level for all services. unless overridden by the service-specific parameters. |
Member
There was a problem hiding this comment.
Suggested change
| help: Default log level for all services. unless overridden by the service-specific parameters. | |
| help: Default log level for all services, unless overridden by the service-specific parameters. |
Contributor
Author
There was a problem hiding this comment.
This line is not applicable to Foreman, so I added a different line that is applicable to Foreman.
stejskalleos
requested changes
Aug 26, 2026
| help: Name of the PAM service to use for IPA authentication | ||
| foreman_log_level: | ||
| help: Log level for Foreman. Defaults to the global log level. | ||
| help: Default log level for all services. unless overridden by the service-specific parameters. |
Contributor
There was a problem hiding this comment.
Suggested change
| help: Default log level for all services. unless overridden by the service-specific parameters. | |
| help: Log level for Foreman. Default log level for all services. unless overridden by the service-specific parameters. |
Contributor
Author
There was a problem hiding this comment.
Same here; it is not required, as mentioned above.
--log-level --foreman-log-level --foreman-proxy-log-level --valkey-log-level --pulp-log-level
amolpati30
force-pushed
the
improve_text_for_log_level_parameter
branch
from
August 26, 2026 19:16
216ba94 to
19ca6c4
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
stejskalleos
requested changes
Aug 27, 2026
stejskalleos
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the help text so that --help provides clear and accurate descriptions for the following parameters:
--log-level
--foreman-log-level
--foreman-proxy-log-level
--valkey-log-level
--pulp-log-level
Previously, the descriptions were not clear. They are now more precise and provide better information about the purpose and behavior of each parameter.