Add z stream and y stream instructions to user upgrade docs. - #787
Add z stream and y stream instructions to user upgrade docs.#787aidenfine wants to merge 3 commits into
Conversation
| - This deploy command will pull new images and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. | ||
|
|
||
| # Z Stream | ||
| ## Upgrading foremanctl from RPM install (Z stream) |
There was a problem hiding this comment.
Ewoud would like us to use "update" for the Z-stream changes.
There was a problem hiding this comment.
It's not just me, I'm following what we introduced in our documentation. https://docs.theforeman.org/nightly/Upgrading_Project/index-katello.html and https://docs.theforeman.org/nightly/Updating_Project/index-katello.html are separate.
| # Y Stream | ||
|
|
||
| ## Upgrading foremanctl from RPM install (Y Stream) |
There was a problem hiding this comment.
| # Y Stream | |
| ## Upgrading foremanctl from RPM install (Y Stream) | |
| # Upgrading foremanctl Y Stream (ex. x.1 to x.2) | |
| ## Upgrading foremanctl from RPM install |
This reads better to me. Feel free to ignore since it's just a style suggestion.
There was a problem hiding this comment.
I like it will change it.
There was a problem hiding this comment.
| 2. Consider backing up your Foreman environment before upgrade. See [Backup and Restore](backup-restore.md). |
This needs updated to the new doc name.
| 4. Upgrade the foremanctl package: | ||
| - `dnf upgrade foremanctl` | ||
| 5. Run upgrade tasks by re-deploying your Foreman environment: | ||
| 5. (Optional) Pre-pull container images to reduce downtime during deploy: |
There was a problem hiding this comment.
This is a great add. Love it.
| - This deploy command will pull new images (if not already pulled in the previous step) and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. | ||
|
|
||
| ## Upgrading foremanctl from disconnected RPM install | ||
| ## Upgrading foremanctl from disconnected RPM install (Y stream) |
There was a problem hiding this comment.
| ## Upgrading foremanctl from disconnected RPM install (Y stream) | |
| ## Upgrading foremanctl from disconnected RPM install |
Just a suggestion to match style tweak above.
| - This deploy command will restart services with the updated images and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. | ||
|
|
||
|
|
||
| ## Upgrading foremanctl from disconnected RPM install (Z stream) |
There was a problem hiding this comment.
| ## Upgrading foremanctl from disconnected RPM install (Z stream) | |
| ## Updating foremanctl from disconnected RPM install |
| All steps must be run as root user. | ||
|
|
||
| 1. On your disconnected environment, run `foremanctl health` to ensure your existing Foreman server is healthy. Correct any issues before continuing. | ||
| 2. Consider backing up your Foreman environment before upgrade. See [Backup](backup.md). |
There was a problem hiding this comment.
One more place to fix the link, sorry. Also "upgrade" -> "update".
| 5. Run upgrade tasks by re-deploying your Foreman environment: | ||
| - `foremanctl deploy` | ||
| - Please see [Parameters](parameters.md) for additional deployment options. | ||
| - This deploy command will restart services with the updated images and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. |
There was a problem hiding this comment.
I confirmed that "This deploy command will restart services" is inaccurate when the image tag does not change. I tested this and systemctl restart foreman.target works best as a step after the deploy since migrations run during the deploy and then the restart flips execution over to the new code on the new images.
| 6. On a connected machine, pull required images and prepare them for transfer: | ||
| - `foremanctl pull-images` | ||
| - Confirm the correct images were downloaded by running `podman images`. All images from your previous-version disconnected environment should be present on the connected environment. If images are missing, ensure foremanctl features parameters are identical between machines. | ||
| - Run `podman save $(podman images --format "{{.Repository}}:{{.Tag}}" | tr '\n' ' ') -o <filename>.tar` to export all downloaded images as a tarball. |
There was a problem hiding this comment.
Aiden have you had any issues with this command? Someone ran into an issue with this downstream (no container tag fails it) but every time I've tarballed the podman images with this it's worked for me.
There was a problem hiding this comment.
I have honestly not run it since I am working on this in parallel with a few other things I have been taking peoples word that it works currently.
I trust that if you and someone else mentioned it works its okay to put in here.
| 11. Run upgrade tasks by re-deploying your Foreman environment: | ||
| - `foremanctl deploy` | ||
| - Please see [Parameters](parameters.md) for additional deployment options. | ||
| - This deploy command will restart services with the updated images and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. |
There was a problem hiding this comment.
Can you add the same additional step as above please? I've confirmed services do not restart as of today.
|
@qcjames53 Does running |
They restart on y stream. The new image tag sets a flag to restart the foreman services on deploy. |
qcjames53
left a comment
There was a problem hiding this comment.
Everything looks great to me! Thanks, Aiden.
| - Please see [Parameters](parameters.md) for additional deployment options. | ||
| - This deploy command will pull new images and run all upgrade jobs required by Foreman, its dependencies, and your configured plugins. Expect this deploy to take longer than typical deploys. | ||
|
|
||
| # Updating foremanctl Z Stream (x.y.1, x.y.2) |
There was a problem hiding this comment.
| # Updating foremanctl Z Stream (x.y.1, x.y.2) | |
| # Updating foremanctl z-stream (x.y.1, x.y.2) | |
There was a problem hiding this comment.
I would almost prefer a separate guide to re-enforce update vs upgrade like we do today in our documentation.
There was a problem hiding this comment.
^ 'y-stream' as well. Thanks Aiden.
There was a problem hiding this comment.
I dont mind creating separate files, I will make a commit tomorrow related to this.
|
Sorry guys got distracted with something else, just pushed the changes to separate the guides |
|
@ehelms How does this look now? |
Why are you introducing these changes? (Problem description, related links)
Old user docs did not include correct steps for Z stream upgrades. I also included the optional
foremanctl pull-imagesstep in Y stream upgrade that could reduce downtown during upgrade.What are the changes introduced in this pull request?