Pulp volume ownership followup (SAT-47249) - #788
Open
lzap wants to merge 3 commits into
Open
Conversation
Define pulp_container_uid and pulp_container_gid in base.yaml alongside pulp_storage_path, and use them in the Pulp role tasks instead of hardcoded UID/GID 700. Co-authored-by: Cursor <cursoragent@cursor.com>
Stop recursing ownership on every deploy. Set owner on new directories without recurse, then chown -R only when a volume path is still root-owned. Apply the same conditional migration after restore, checking storage and media paths so root-based backup content is corrected once. Co-authored-by: Cursor <cursoragent@cursor.com>
Podman reads secret files when creating mounts; containers do not bind-mount these paths directly. Restore root:root ownership for django_secret_key and database_fields.symmetric.key after deploy and restore migrations. Co-authored-by: Cursor <cursoragent@cursor.com>
lzap
commented
Aug 26, 2026
| ( | ||
| restore_pulp_media_ownership.stat.exists and | ||
| restore_pulp_media_ownership.stat.uid == 0 | ||
| ) |
Member
Author
There was a problem hiding this comment.
I am not sure if checking media is necessary, just the root (storage) ownership might be enough.
ehelms
reviewed
Aug 26, 2026
| owner: "700" | ||
| group: "700" | ||
| owner: root | ||
| group: root |
Member
There was a problem hiding this comment.
Why do these get owned by root instead of the pulp user?
ehelms
reviewed
Aug 26, 2026
| register: restore_pulp_media_ownership | ||
|
|
||
| - name: Fix ownership after restore for non-root containers | ||
| - name: Migrate restored Pulp storage ownership from root to container user |
Member
There was a problem hiding this comment.
@sjha4 Can you take a look at the restore changes included in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few changes as a follow-up to #734