Remove valueless recurring timer last-trigger test - #791
Open
ehelms wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
@archanaserver one more for you to consider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The test provids no unique value:
test_foreman_recurring_timer_next_triggeralready proves each timer is scheduled to fire, and
test_foreman_recurring_timer_executionalready proves the service and itscontainer plumbing actually run. Asserting that systemd recorded a past
trigger timestamp verifies nothing about the deployment's correctness.
See failures: https://github.com/theforeman/foreman-oci-images/actions/runs/33086235201/job/98566514040?pr=91
What are the changes introduced in this pull request?
test_foreman_recurring_timer_last_triggertest, which wasdeploy-timing-dependent and duplicated coverage already provided by the
next-trigger and execution tests.
How to test this pull request
Steps to reproduce:
tests:
python -m pytest tests/feature/foreman/base_test.py -vv -k recurringre-deploy) — previously
test_foreman_recurring_timer_last_trigger[monthly]would fail in that scenario.
Checklist