Update RuboCop and enable in CI - #1606
Open
ekohl wants to merge 1 commit into
Open
Conversation
ekohl
force-pushed
the
rubocop-update
branch
from
November 17, 2022 13:28
982aa49 to
b0b287b
Compare
ekohl
commented
Nov 17, 2022
ekohl
marked this pull request as draft
November 17, 2022 13:30
ekohl
force-pushed
the
rubocop-update
branch
2 times, most recently
from
November 17, 2022 15:11
edfbeea to
38ae935
Compare
ekohl
marked this pull request as ready for review
November 17, 2022 15:11
Member
Author
|
No idea why the annotations aren't working, but this is otherwise working as intended. |
wbclark
reviewed
Apr 10, 2023
wbclark
left a comment
wbclark
left a comment
Contributor
There was a problem hiding this comment.
Should this be called something like "enable rubocop in CI" ? I would be in favor of doing so.
I would like to look at this but the logs are expired and there are merge conflicts now. Would you consider this important enough to revisit?
Member
Author
|
I'm updating this, but now that I see it I saw a note about EL8 having Ruby 2.5 by default. I wonder if that's a concern for our CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1605. Ruby 2.5 was chosen because EL8 ships Ruby 2.5 by default.