Skip to content

Fixes #38611 - Ldap group membership #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofedoren merged 1 commit into from
Jul 23, 2025
Merged

Fixes #38611 - Ldap group membership #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/hammer_cli_foreman/auth_source_ldap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ class InfoCommand < HammerCLIForeman::InfoCommand
field :account, _('Account Username')
field :base_dn, _('Base DN')
field :groups_base, _('Groups base DN')
field :use_netgroups, _('Use Netgroups'), Fields::Boolean
Copy link
Copy Markdown
Member

@ofedoren ofedoren Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still present in the response, should we rather just add ldap_group_membership?

We also can mark use_netgroups as deprecated in case we're going to drop that:

field :ldap_group_membership, _('LDAP group membership')
field :use_netgroups, _('Use Netgroups'), Fields::Boolean, :replaced_by => [_('Account'), _('LDAP group membership')].join('/')

Copy link
Copy Markdown
Contributor Author

@adamruzicka adamruzicka Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat, added

field :use_netgroups, _('Use Netgroups'), Fields::Boolean, :replaced_by => [_('Account'), _('LDAP group membership')].join('/')
field :ldap_group_membership, _('LDAP group membership')
field :ldap_filter, _('LDAP filter')
field :onthefly_register, _('Automatically Create Accounts?'), Fields::Boolean
field :usergroup_sync, _('Usergroup sync'), Fields::Boolean
Expand Down