Skip rediscovery for unchanged AST#130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an incremental parsed-AST layer to tryke_discovery so discovery can be skipped when source edits do not change the parsed AST, and updates public documentation examples to use direct tryke imports.
Changes:
- Introduces
ParsedAstandparse_fileas a Salsa-tracked parsing layer before file discovery. - Refactors discovery to consume parsed ASTs and adds a regression test for unchanged-AST edits.
- Updates README and docs examples from
t.*usage to direct imports.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
crates/tryke_discovery/src/db.rs |
Adds ParsedAst, tracked parsing, and test-only discovery execution counting. |
crates/tryke_discovery/src/lib.rs |
Refactors discovery from source parsing to AST-based discovery. |
crates/tryke_discovery/src/discoverer.rs |
Adds regression coverage for unchanged AST rediscovery behavior. |
README.md |
Updates example imports and call sites to direct tryke symbols. |
docs/index.md |
Mirrors README example import and call-site updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Discovery was keyed directly off source text, so trivia-only edits still forced test rediscovery even when the parsed AST did not change.
Changes
describe,Depends,fixture,test, andexpectdirectly instead of usingt.*qualification.Test plan
cargo test -p tryke_discoverycargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --all-featuresuv run cargo run -- test --reporter llmuvx prek run -a