Implemented state pattern on DatabaseConnector class#202
Open
Jbasilious wants to merge 16 commits intotheleadio:masterfrom
Open
Implemented state pattern on DatabaseConnector class#202Jbasilious wants to merge 16 commits intotheleadio:masterfrom
Jbasilious wants to merge 16 commits intotheleadio:masterfrom
Conversation
Create aggregate function get_and_parse to manage all parsing functions
Implemented an aggregate class called URLParser to handle all URL parsing, both html and xml.
deleted excess code leading to errors and excess comments
Aggregate #1 Implementation
added RSS aggregation class
Aggregate #2
created a metaclass called "MetaDatabaseConnector" for the "DatabaseConnector" class in order to implement a singleton pattern. this will aid with database integrity
Refactor db_connector.py to utilize singleton pattern
created a metaclass called "MetaDatabaseConnector" for the "DatabaseConnector" class in order to implement a singleton pattern. this will aid with database integrity
Modify db_connector.py to utilize singleton pattern
Implemented the state behavioral pattern on the DatabaseConnector class. This will reduce complexity when accessing databases the individual table methods can all be accessed using the insert method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- Only most recent commit is relevant --
Implemented the state behavioral design pattern onto the Database Connector Class,
Used DatabaseConnector class as the context class, defined an abstract class "AbstractState" , created one new class using AbstractState for each state required. there is one state per table format.
table format specific insert functions have all be replaced with a single insert(data_dict, table_name) function. this will help aid in expandability and reduce complexity later on.