Retain the git package after install to support plugins that need it - #216
Merged
Conversation
offbyone
force-pushed
the
retain-the-git-package-after-install-to-support-plugins-that-need/uzsvxtqtxwmr
branch
from
August 1, 2026 14:13
3fb69d5 to
9b351ce
Compare
MaxLeiter
approved these changes
Aug 1, 2026
Member
|
thank you! |
MaxLeiter
reviewed
Aug 1, 2026
| ENV NODE_ENV production | ||
| RUN apk --update --no-cache --virtual build-deps add python3 py3-setuptools build-base git && \ | ||
| RUN apk --update --no-cache --virtual build-deps add python3 py3-setuptools build-base && \ | ||
| apk add git && \ |
Member
There was a problem hiding this comment.
I believe this should also have --no-cache
Suggested change
| apk add git && \ | |
| apk --no-cache add git && \ |
This ensures that plugins that need git to install can find it.
offbyone
force-pushed
the
retain-the-git-package-after-install-to-support-plugins-that-need/uzsvxtqtxwmr
branch
from
August 1, 2026 17:13
9b351ce to
f8df63f
Compare
MaxLeiter
approved these changes
Aug 1, 2026
MaxLeiter
enabled auto-merge (squash)
August 1, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215