Skip to content

chore: support Node 24 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mashbean merged 1 commit into from
May 15, 2026
Merged

chore: support Node 24 #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ jobs:
uses: actions/checkout@master

- name: Setup Node.js
uses: actions/setup-node@v2.1.4
uses: actions/setup-node@v4
with:
node-version: '18.19'
node-version: '24'
registry-url: 'https://registry.npmjs.org'
always-auth: true

- name: Cache Dependencies
id: cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node24-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
${{ runner.os }}-node24-

- name: Install Dependencies
run: npm ci
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,28 @@ on:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['18.19', '24']
steps:
- name: Checkout Repo
uses: actions/checkout@master

- name: Setup Node.js
uses: actions/setup-node@v2.1.4
uses: actions/setup-node@v4
with:
node-version: '18.19'
node-version: ${{ matrix.node-version }}
registry-url: 'https://registry.npmjs.org'
always-auth: true

- name: Cache Dependencies
id: cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
${{ runner.os }}-node${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
Expand Down
1 change: 0 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
unsafe-perm=true
legacy-peer-deps=true
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@matters/matters-editor",
"version": "0.3.1",
"version": "0.3.2",
"description": "Editor for matters.news",
"author": "https://github.com/thematters",
"homepage": "https://github.com/thematters/matters-editor",
Expand All @@ -9,7 +9,7 @@
"url": "git@github.com:thematters/matters-editor.git"
},
"engines": {
"node": ">=18.19 <19.0"
"node": ">=18.19 <25.0.0"
},
"license": "MIT",
"type": "module",
Expand Down
Loading