[codex] Run Node 24 checks on pull requests#521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the existing Node 18.19 and Node 24 test matrix run on pull requests, and updates the checkout action in that workflow to
actions/checkout@v4.Why
matters-editoris a shared package consumed by other Matters repos. It already has a Node 24 test matrix, but PRs should show that matrix directly before downstream repos move to Node 24.This PR does not change package code, runtime requirements, or dependencies.
Validation
npm cinpm run lint && npm run test, 71 tests passednpx -y node@24 ./node_modules/vitest/vitest.mjs --run, 71 tests passednpm run build, completed with existing Rollup warningsRollback
Revert this workflow-only commit. Runtime behavior and published package output are unchanged.