[codex] Add Node 24 compatibility CI#4847
Open
mashbean wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4847 +/- ##
===========================================
+ Coverage 72.57% 72.68% +0.10%
===========================================
Files 1067 1067
Lines 21164 21259 +95
Branches 4619 4691 +72
===========================================
+ Hits 15360 15452 +92
- Misses 5327 5328 +1
- Partials 477 479 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
01706d8 to
6749b72
Compare
6749b72 to
c1ac158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Node 24 compatibility lane to the existing reusable build workflow while keeping the default runtime on Node 18.
Changes:
engines.nodeto allow Node 18 and Node 24node_versioninput to.github/workflows/build.yml, defaulting to18actions/checkout@v4npm cican run under Node 24Why
This is the compatibility PR only. Deploy workflows that do not pass
node_versionstill use the default Node 18 path, and the Dockerfile remains onnode:18-alpine. That preserves the current production rollback line while allowing CI to prove Node 24 compatibility.Validation
npx -p node@24 -p npm@11 npm ci, passed with an existing@matters/matters-editor@0.3.0-alpha.4engine warningnpx -y node@24 -e "import('bcrypt').then(...)", confirmed bcrypt loadsnpx -y node@24 node_modules/typescript/bin/tsc -p ., passednpx -p node@24 -p npm@11 npm run lint, passednpx -p node@18 -p npm@10 npm ci --ignore-scripts, passed as lockfile rollback-line checkFull test execution is left to GitHub Actions because the workflow provides Redis, Postgres, and stripe-mock services.
Known follow-up
@matters/matters-editor@0.3.0-alpha.4declaresnode >=18.19 <19.0, so npm emits an engine warning under Node 24. It is not a hard install failure. The shared-package follow-up should publish or consume a Node 24-compatible editor package before production runtime cutover.Rollback
Revert this PR, or leave it merged and omit
node_versionfrom deployment workflow calls. The reusable workflow defaults to Node 18, and the Dockerfile still uses Node 18.