feat(campaign): enableQuoteWall flag to gate the quote wall#4857
Merged
Conversation
- add `enable_quote_wall` boolean column to campaign (default false), with a one-time backfill enabling it for existing 七日書 campaigns (name match used once at migration time; data-driven thereafter) - expose `enableQuoteWall` on WritingChallenge + PutWritingChallengeInput, wired through the resolver, campaignService, and putWritingChallenge - putQuote now rejects posting to a campaign whose quote wall is not enabled — server-side authoritative gate (the old check only required the article to belong to any campaign) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… test The new putQuote gate rejects campaigns whose quote wall is disabled, so the existing happy-path test (campaign defaulted to enable_quote_wall=false) broke. Enable the wall on the seed campaign and add a test covering the rejection. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4857 +/- ##
========================================
Coverage 72.68% 72.68%
========================================
Files 1068 1070 +2
Lines 21246 21262 +16
Branches 4641 4642 +1
========================================
+ Hits 15442 15454 +12
- Misses 5325 5329 +4
Partials 479 479 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a per-campaign
enableQuoteWallflag so only opted-in campaigns (e.g. 七日書) expose the quote wall / post-to-wall.Changes
enable_quote_wallboolean tocampaign(default false)enableQuoteWallonWritingChallenge+PutWritingChallengeInput, wired through resolver / campaignService / putWritingChallengeputQuote: server-side authoritative gate — reject posting to a campaign whose quote wall is not enabled (was: any campaign article)Notes