Skip to content

feat(campaign): default the quote wall on for every campaign#4858

Merged
yingshinlee merged 1 commit into
developfrom
feat/campaign-quote-wall-default-on
Jun 18, 2026
Merged

feat(campaign): default the quote wall on for every campaign#4858
yingshinlee merged 1 commit into
developfrom
feat/campaign-quote-wall-default-on

Conversation

@yingshinlee

Copy link
Copy Markdown
Collaborator

過渡決定:先取消「只有七日書」限制,讓所有活動都能上金句牆

  • migration:把 enable_quote_wall 預設改 true、現有活動全設 true。
  • 不動 OSS(豆泥正在重寫 OSS);也不動前端(#5976 已在讀這個旗標 → 全 true → 每個活動文章都顯示上牆鈕)。
  • per-campaign 旗標保留,當作日後掛勾:之後要做七日書專屬,可(a)程式碼判定(名稱/shortHash)或(b)等新 OSS 接這個欄位,皆無需改 schema。

base=develop→ICU。

Interim: drop the 七日書-only restriction and open the quote wall for all
campaigns. Flip enable_quote_wall default to true and enable it on all existing
campaigns. The per-campaign flag is kept as a future hook (OSS toggle /
七日書-only restriction can be wired to it later without a schema change).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yingshinlee yingshinlee requested a review from a team as a code owner June 17, 2026 12:05
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.77%. Comparing base (915098c) to head (e02b423).
⚠️ Report is 39 commits behind head on develop.

Files with missing lines Patch % Lines
...200_alter_campaign_enable_quote_wall_default_on.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4858      +/-   ##
===========================================
- Coverage    72.93%   72.77%   -0.17%     
===========================================
  Files         1068     1071       +3     
  Lines        21541    21310     -231     
  Branches      4802     4659     -143     
===========================================
- Hits         15712    15509     -203     
+ Misses        5347     5324      -23     
+ Partials       482      477       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yingshinlee yingshinlee merged commit 54e496a into develop Jun 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant