feat(campaign): open the discussion to any logged-in user#4859
Merged
Conversation
Relax the campaign-discussion comment permission from "only succeeded participants (or organizers)" to any logged-in user. Basic user-state and campaign-state guards are unchanged. Tests updated: non-participant / pending / rejected applicants can now comment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4859 +/- ##
===========================================
- Coverage 72.93% 72.76% -0.18%
===========================================
Files 1068 1070 +2
Lines 21541 21295 -246
Branches 4802 4654 -148
===========================================
- Hits 15712 15496 -216
+ Misses 5347 5322 -25
+ Partials 482 477 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
放寬活動討論區留言權限:從「只有報名成功者/主辦」改成「任何登入用戶皆可留言」。基本的帳號狀態(banned/frozen)與活動封存 guard 不變。測試已更新(non-participant/pending/rejected 現在都能留言)。base=develop→ICU。
搭配前端會另開一支:canComment 改 viewer.isAuthed、留言點讚 hasUpvote、長留言收回鈕、輸入框框內發布。