ci: add production topic channel spam audit mode#4866
Closed
mashbean wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4866 +/- ##
==========================================
+ Coverage 73.12% 73.39% +0.26%
==========================================
Files 1081 1081
Lines 21644 21874 +230
Branches 4735 4824 +89
==========================================
+ Hits 15828 16055 +227
- Misses 5339 5342 +3
Partials 477 477 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing this audit workflow PR. Merging query-only incident tooling into master is not the right production boundary for this check. We should run the read-only SQL through an existing approved DB access path or have an operator run it directly, without changing the production branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We need a read-only production DB audit for the topic-channel spam exposure incident. The existing production query workflow already has VPN, production environment approval, and DB access boundaries, but it only supports federation export event lookup.
What changed
article_id=0audit mode to the existing production query workflow.Safety
environment: production, so branch policy and required reviewers remain enforced.Validation
mainandmaster, confirming this must land on an allowed branch before it can access production.