feat(campaign): discussion board on campaign detail page#5967
Merged
Conversation
- CampaignDetail/Discussion: compact module (desktop right aside) with input box + latest 3 comments + view-all dialog; mobile renders a one-line chip entry that opens the dialog - reuse CircleComment family: CircleCommentForm/Dialog accept campaignId and type campaignDiscussion; ReplyButton/DropdownActions resolve campaign node - 240-char cap with counter on campaign comments (matches moments) - layout: cover height halved (23.26% -> 12%), side participants avatars trimmed 60 -> 12 to make room for the discussion module Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…mponents Backend added `campaignDiscussion` to the GraphQL `CommentType` enum, widening the codegen type. Propagate the new type through the hand-written comment routing/UI so type-checking and build pass: - route.ts: add `campaignDiscussion` to `CommentArgs.type` and resolve the comment link to the campaign detail page via the existing campaignDetail route - CircleComment/CreatedAt: link campaign discussion comments to their campaign - CampaignDetail/Discussion: fix discussion connection type (campaign field is no longer a union, so drop the never-yielding Extract) - correct formatjs message ids and extract new i18n strings - fix stylelint ordering/comment-spacing in new campaign styles Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The popover was gated on contentContainer.current in render; assigning a ref does not trigger a re-render, so it only appeared after an unrelated re-render (e.g. scroll). Gate on a mounted flag set in an effect instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream CI mirror of #5964（原 PR 來自 fork yingshinlee，fork 觸發的 CI 拿不到 secrets、build required check 不會跑）。
此 PR 從 thematters/matters-web 內部分支開啟，讓 CI 能在帶 secrets 的 context 跑、codegen 抓 server.matters.icu 的新 schema（campaign discussion / quote wall 後端已於今日部署上 staging）。
內容與 #5964 相同。Co-Authored-By: Claude Fable 5