Skip to content

hotfix(circle-sunset): re-hide circle entry reopened on master #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mashbean wants to merge 1 commit into from
Closed

hotfix(circle-sunset): re-hide circle entry reopened on master #5973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/views/User/UserProfile/AsideUserProfile/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ import {
SeedBadge,
TraveloggersBadge,
} from '../Badges'
import CircleWidget from '../CircleWidget'
// FEATURE IS SUNSETTING: circle entry on aside user profile is hidden
// import CircleWidget from '../CircleWidget'
import DropdownActions from '../DropdownActions'
import { FollowersDialog } from '../FollowersDialog'
import { FollowingDialog } from '../FollowingDialog'
Expand Down Expand Up @@ -114,7 +115,8 @@ export const AsideUserProfile = () => {
}

const badges = user.info.badges || []
const circles = user.ownCircles || []
// FEATURE IS SUNSETTING: circle entry on aside user profile is hidden
// const circles = user.ownCircles || []
const hasSeedBadge = badges.some((b) => b.type === 'seed')
const hasArchitectBadge = badges.some((b) => b.type === 'architect')
const hasGoldenMotorBadge = badges.some((b) => b.type === 'golden_motor')
Expand Down Expand Up @@ -374,11 +376,12 @@ export const AsideUserProfile = () => {
)}
</section>

{isInUserPage && (
{/* FEATURE IS SUNSETTING: circle entry on aside user profile is hidden */}
{/* {isInUserPage && (
<footer className={styles.footer}>
<CircleWidget circles={circles} isMe={isMe} />
</footer>
)}
)} */}
</section>
)
}
Expand Down
11 changes: 7 additions & 4 deletions src/views/User/UserProfile/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ import { UserProfileUserPublicQuery } from '~/gql/graphql'
import UserTabs from '../UserTabs'
import { Badges } from './Badges'
import { BadgesDialog } from './BadgesDialog'
import CircleWidget from './CircleWidget'
// FEATURE IS SUNSETTING: circle entry on user profile is hidden
// import CircleWidget from './CircleWidget'
import DropdownActions from './DropdownActions'
import { FollowersDialog } from './FollowersDialog'
import { FollowingDialog } from './FollowingDialog'
Expand Down Expand Up @@ -102,7 +103,8 @@ export const UserProfile = () => {
}

const badges = user.info.badges || []
const circles = user.ownCircles || []
// FEATURE IS SUNSETTING: circle entry on user profile is hidden
// const circles = user.ownCircles || []
const hasSeedBadge = badges.some((b) => b.type === 'seed')
const hasArchitectBadge = badges.some((b) => b.type === 'architect')
const hasGoldenMotorBadge = badges.some((b) => b.type === 'golden_motor')
Expand Down Expand Up @@ -306,12 +308,13 @@ export const UserProfile = () => {
</p>
</Expandable>

<CircleWidget
{/* FEATURE IS SUNSETTING: circle entry on user profile is hidden */}
{/* <CircleWidget
circles={circles}
isMe={isMe}
hasDescription={false}
hasFooter={false}
/>
/> */}
</section>
</Media>
</section>
Expand Down
Loading