hotfix(circle-sunset): re-hide circle entry on production (v6.11.2)#5977
Merged
Conversation
The circle widget entry on both the user profile and aside user profile was accidentally re-enabled by 4acdd20 ("Display carbon based badge"). That Codex-generated commit rewrote these two files from a pre-sunset view and un-commented the CircleWidget import / circles var / render, reopening the circle (圍爐) entrance that the sunset series (ed1108c / 814c776) had intentionally hidden. Re-apply the sunset comments to all three spots in both files while keeping the CarbonBasedBadge additions intact. Present on both develop and master, so this also needs to reach master. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The required `build` check generates GraphQL types against the staging schema (server.matters.icu), whose CommentType already exposes `campaignDiscussion`. The manually-typed CommentArgs.type union here only listed four values, so every comment component failed tsc with "CommentType is not assignable". Widen the union to include `campaignDiscussion`. This is schema-agnostic and production-safe: staging fragments carrying the value are now assignable, while the production schema (which omits it) stays a subset. No switch case is added — full campaignDiscussion routing ships with the develop release; this hotfix only needs the type to compile so the circle-sunset fix can deploy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The #5974 revert reverted these two unrelated files (fediverse UI and a test helper) back to their pre-release state, which introduced prettier drift and neither relates to the quote-wall/campaign-discussion code being removed. Pin them to current master so this hotfix does not touch them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Production hotfix — 關閉線上圍爐入口
為什麼需要這個 PR
線上 matters.town 的圍爐（Circle）入口仍開著。先前 release #5974（develop→master）雖含圍爐修復，但 production EB 部署掛在
Generate Types (production)：develop 帶的 quote-wall 前端碼依賴PutQuoteInput等 server 型別，而 production server 尚未部署（matters-server develop 領先 master 48 commits）。結果 production 部署中止、仍是舊 build、圍爐入口仍開。這個 hotfix 做什麼（外科手術式，不動後端）
gen:type:prod（production schema）不再缺型別 → production 部署能過。CommentArgs.type加寬campaignDiscussion：requiredbuildcheck（push 事件走 staging schema）需要；對 staging（含）與 production（子集）兩邊都安全。Create Release重複 v6.11.1 tag 的失敗。本地驗證（雙 schema）
gen:type(staging) +tsc --noEmit：零錯誤gen:type:prod(production) +tsc --noEmit：零錯誤format:check/ ESLint / stylelint：乾淨quote-wall / campaign-discussion 仍在 develop，要正式上 production 需先發 matters-server（提供
PutQuoteInput、campaignDiscussionschema）再發 matters-web，屆時此 revert 需一併處理（revert-the-revert 或重新 merge）。🤖 Generated with Claude Code