fix(campaign): logged-in discussion polish (spacing, alignment, centering)#5980
Merged
Conversation
…ring) Issues found once testing the logged-in discussion on ICU: - centre the "view all N comments" link in the module - restore a gap below the comment box (the inline-footer variant had margin-bottom:0, gluing the first comment to the box) and compact the editor min-height inside that box (scoped via the global u-content-comment class so 圍爐 is untouched) - align 24px-avatar reply text under the author name (the .contentContainer indent was sized for the 32px avatar) — scoped to campaignDiscussion Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…pping - revert the centered "view all N comments" link back to left-aligned, matching the site's ViewMoreComment convention (text-align: start); nothing on the site centers this line - pass nameNoWrap to the comment author for campaign discussion so the display name + @id stay on one line; in the indented reply column they otherwise wrap to two lines and the name↔id gap looks cramped Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- the counter used var(--color-red), which is undefined, so it never turned red past the limit; use --color-negative-red, the site-wide form-error red (ArticleCommentForm / Form.Field use the same) - the campaign submit label was 15px; drop to 14px to match the site's comment submit buttons (ArticleCommentForm), scoped so circle forms keep their size Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ange) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在 ICU 登入態測出的討論區排版問題修正（接續 #5978）。base =
develop。修正項目
margin-bottom:0，導致彈窗內表單緊貼第一則留言 → 補回sp16min-height縮為3rem（透過全域 classu-content-comment限定，圍爐不受影響）.contentContainer縮排原本為 32px 頭像設計（sp40），二級用 24px 頭像 → 文字往後縮半格；新增 compact 縮排（sp32）對齊名稱，僅限 campaignDiscussion待辦（需實機微調）
驗證
tsc --noEmit綠