added support for 2d weights#221
Open
KrishnaAgarwal1308 wants to merge 1 commit intotheochem:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage ? 92.67%
=======================================
Files ? 11
Lines ? 833
Branches ? 0
=======================================
Hits ? 772
Misses ? 61
Partials ? 0
🚀 New features to boost your workflow:
|
Collaborator
|
Hi @KrishnaAgarwal1308. Could you please correct the errors related to the coding style in the automated tests? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the files edited are utils.py in procrustes dir and test_utils.py in procrustes/test. In response to issue #202 (comment)
edits:-
utils.py
Keeping the previous functionality for 1d weight matrix and none weight matrix added the support for 2d weight matrix to _translate_array, _setup_input_array_lower and added _is_psd to check if the weight is psd matrix or not.
test_uitls.py
all previous code intact with addition of est_translate_with_2d_weight_uses_ordinary_mean()