Skip to content

added support for 2d weights#221

Open
KrishnaAgarwal1308 wants to merge 1 commit intotheochem:mainfrom
KrishnaAgarwal1308:2d-weight
Open

added support for 2d weights#221
KrishnaAgarwal1308 wants to merge 1 commit intotheochem:mainfrom
KrishnaAgarwal1308:2d-weight

Conversation

@KrishnaAgarwal1308
Copy link
Copy Markdown

the files edited are utils.py in procrustes dir and test_utils.py in procrustes/test. In response to issue #202 (comment)

edits:-
utils.py
Keeping the previous functionality for 1d weight matrix and none weight matrix added the support for 2d weight matrix to _translate_array, _setup_input_array_lower and added _is_psd to check if the weight is psd matrix or not.

test_uitls.py
all previous code intact with addition of est_translate_with_2d_weight_uses_ordinary_mean()

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8f1173a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
procrustes/utils.py 62.50% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage        ?   92.67%           
=======================================
  Files           ?       11           
  Lines           ?      833           
  Branches        ?        0           
=======================================
  Hits            ?      772           
  Misses          ?       61           
  Partials        ?        0           
Files with missing lines Coverage Δ
procrustes/utils.py 77.24% <62.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FanwangM
Copy link
Copy Markdown
Collaborator

FanwangM commented Nov 3, 2025

Hi @KrishnaAgarwal1308. Could you please correct the errors related to the coding style in the automated tests? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants