Outlined how disabling the id generator could be fixed#111
Closed
Toflar wants to merge 1 commit into
Closed
Conversation
Merged
Owner
|
Closed by #195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's just quickly outlined how #110 could be fixed.
The core issue here is just that we need to be able to disable id generation for all objects before any of them is persisted so I had to add a new interface which I - creative as I am - named
ExtendedProcessorInterface. All I did then was moving the logic away from theObjectManagerPersisterinto a processor that uses this new interface.This is how the issue could be fixed. /cc @dkarlovi