Skip to content

Disable FK checks also on DELETE #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theofidry merged 7 commits into from
Sep 2, 2019
Merged

Disable FK checks also on DELETE #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c1b85e
Disable FK checks also on DELETE
tifabien Jul 31, 2019
7e689a4
Fix weak_vendors deprecation notice
tifabien Aug 5, 2019
cffd73a
Add unit test when using delete purge mode
tifabien Aug 5, 2019
aeb6a40
Update SYMFONY_DEPRECATIONS_HELPER variable
tifabien Aug 5, 2019
9810518
Update SYMFONY_DEPRECATIONS_HELPER variable
tifabien Aug 5, 2019
55f87fc
Prevent install of proxyManager too recent
tifabien Aug 5, 2019
a094b49
Update SYMFONY_DEPRECATIONS_HELPER variable
tifabien Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_doctrine.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />

<env name="DB_DRIVER" value="pdo_mysql" />
<env name="DB_USER" value="root" />
Expand Down
2 changes: 1 addition & 1 deletion phpunit_doctrine_mongodb.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_doctrine_phpcr.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="4" />

<env name="DB_DRIVER" value="pdo_mysql" />
<env name="DB_USER" value="root" />
Expand Down
2 changes: 1 addition & 1 deletion phpunit_eloquent.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />

<env name="DB_DRIVER" value="mysql" />
<env name="DB_USER" value="root" />
Expand Down
2 changes: 1 addition & 1 deletion phpunit_propel2.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_symfony.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_symfony_doctrine.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="5" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_symfony_eloquent.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_symfony_proxy_manager_with_doctrine.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="5" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion phpunit_symfony_proxy_manager_with_eloquent.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
verbose="true">

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="0" />
</php>

<testsuites>
Expand Down
10 changes: 5 additions & 5 deletions src/Bridge/Doctrine/Purger/Purger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,25 +91,25 @@ public function create(PurgeMode $mode, PurgerInterface $purger = null): PurgerI
*/
public function purge()
{
// Because MySQL rocks, you got to disable foreign key checks when doing a TRUNCATE unlike in for example
// Because MySQL rocks, you got to disable foreign key checks when doing a TRUNCATE/DELETE unlike in for example
// PostgreSQL. This ideally should be done in the Purger of doctrine/data-fixtures but meanwhile we are doing
// it here.
// See the progress in https://github.com/doctrine/data-fixtures/pull/272
$truncateOrm = (
$disableFkChecks = (
$this->purger instanceof DoctrineOrmPurger
&& PurgeMode::createTruncateMode()->getValue() === $this->purgeMode->getValue()
&& in_array($this->purgeMode->getValue(), [PurgeMode::createDeleteMode()->getValue(), PurgeMode::createTruncateMode()->getValue()])
&& $this->purger->getObjectManager()->getConnection()->getDriver() instanceof AbstractMySQLDriver
);

if ($truncateOrm) {
if ($disableFkChecks) {
$connection = $this->purger->getObjectManager()->getConnection();

$connection->exec('SET FOREIGN_KEY_CHECKS = 0;');
}

$this->purger->purge();

if ($truncateOrm && isset($connection)) {
if ($disableFkChecks && isset($connection)) {
$connection->exec('SET FOREIGN_KEY_CHECKS = 1;');
}
}
Expand Down
26 changes: 26 additions & 0 deletions tests/Bridge/Doctrine/Purger/PurgerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
namespace Fidry\AliceDataFixtures\Bridge\Doctrine\Purger;

use Doctrine\Common\DataFixtures\Purger\ORMPurger as DoctrineOrmPurger;
use Doctrine\DBAL\Driver\AbstractMySQLDriver;
use Doctrine\DBAL\Connection;
use Doctrine\ORM\EntityManager;
use Fidry\AliceDataFixtures\Bridge\Doctrine\Entity\Dummy;
use Fidry\AliceDataFixtures\Bridge\Doctrine\ORM\FakeEntityManager;
Expand Down Expand Up @@ -59,6 +61,30 @@ public function testCreatesADoctrineOrmPurgerWithTheAppropriateManagerAndPurgeMo
$this->assertEquals(DoctrineOrmPurger::PURGE_MODE_TRUNCATE, $decoratedPurger->getPurgeMode());
}

public function testDisableFKChecksOnDeleteIsPerformed()
{
$connection = $this->prophesize(Connection::class);
$connection->getDriver()->willReturn($this->prophesize(AbstractMySQLDriver::class)->reveal());
$connection->exec('SET FOREIGN_KEY_CHECKS = 0;')->shouldBeCalled();
$connection->exec('SET FOREIGN_KEY_CHECKS = 1;')->shouldBeCalled();

$manager = $this->prophesize(EntityManager::class);
$manager->getConnection()->willReturn($connection->reveal());

$purgerORM = $this->prophesize(DoctrineOrmPurger::class);
$purgerORM->getObjectManager()->willReturn($manager->reveal());
$purgerORM->purge()->shouldBeCalled();

$purgeMode = PurgeMode::createDeleteMode();
$purger = new Purger($manager->reveal(), $purgeMode);

$decoratedPurgerReflection = (new \ReflectionObject($purger))->getProperty('purger');
$decoratedPurgerReflection->setAccessible(true);
$decoratedPurgerReflection->setValue($purger, $purgerORM->reveal());

$purger->purge();
}

public function testEmptyDatabase()
{
/** @var EntityManager $manager */
Expand Down
2 changes: 1 addition & 1 deletion vendor-bin/proxy-manager/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"doctrine/phpcr-bundle": "^1.0",
"doctrine/phpcr-odm": "^1.4",
"jackalope/jackalope-doctrine-dbal": "^1.2",
"ocramius/proxy-manager": "^2.0.2",
"ocramius/proxy-manager": "^2.0.2, < 2.2.0",
"psy/psysh": "^0.6",
"symfony/symfony": "^3.4 || ^4.0",
"theofidry/composer-inheritance-plugin": "^1.0",
Expand Down