Skip to content

Defer Ruffle and remove hover shadows to reduce INP latency #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoneand33 merged 3 commits into from
Sep 10, 2026
Merged

Defer Ruffle and remove hover shadows to reduce INP latency #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a45e384
perf: defer ruffle.js and remove hover shadows to reduce INP latency
theoneand33 Sep 10, 2026
e9b1d0e
agent: fail fast on ruffle 404 via onerror, keep polling for slow net…
theoneand33 Sep 10, 2026
639a105
agent: cap ruffle polling at 75 attempts (~15s) per review nit (#85)
theoneand33 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/flash.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const { gamePath } = Astro.props;
}
</style>

<script src="/ruffle/ruffle.js" is:inline></script>
<script src="/ruffle/ruffle.js" defer is:inline onerror="window.__ruffleFailed=true"></script>
<script is:inline>
(function () {
var wrap = document.getElementById("flash-player-wrap");
Expand Down Expand Up @@ -107,12 +107,17 @@ const { gamePath } = Astro.props;
});
}

// ── Ruffle readiness (polling fallback) ──
var maxAttempts = 50;
// ── Ruffle readiness (polling fallback, covers deferred ruffle.js) ──
var maxAttempts = 75;
var attempts = 0;

function ready() {
if (destroyed) return;
// ponytail: fail fast on script 404/offline, keep polling for slow networks
if (window.__ruffleFailed) {
showError("Failed to load Flash player. Please refresh the page.");
return;
}
try {
var ruffle =
typeof window.RufflePlayer !== "undefined" &&
Expand Down
2 changes: 1 addition & 1 deletion src/components/gametile.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const altText = `${Game} unblocked - play online free`;
height="200"
loading="lazy"
decoding="async"
class="aspect-[3/2] h-auto w-full max-w-[300px] rounded-xl transition-transform duration-300 hover:scale-105 hover:shadow-lg active:scale-95"
class="aspect-[3/2] h-auto w-full max-w-[300px] rounded-xl transition-transform duration-300 hover:scale-105 active:scale-95"
/>
<p class="text-gray-800 dark:text-neutral-200 transition-colors hover:text-black dark:hover:text-white">{Game}</p>
</a>
2 changes: 1 addition & 1 deletion src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const popularGames = defaultGames.slice(0, POPULAR_COUNT);
img.loading = "lazy";
img.decoding = "async";
img.className =
"aspect-[3/2] h-auto w-full max-w-[300px] rounded-xl transition-transform duration-300 hover:scale-105 hover:shadow-lg active:scale-95";
"aspect-[3/2] h-auto w-full max-w-[300px] rounded-xl transition-transform duration-300 hover:scale-105 active:scale-95";
var p = document.createElement("p");
p.className = "text-gray-800 dark:text-neutral-200 transition-colors hover:text-black dark:hover:text-white";
p.textContent = g.t;
Expand Down
Loading