build: consume zh_CN catalogs from the guidebook submodule (single home)#11
Draft
sanchuanhehe wants to merge 1 commit into
Draft
build: consume zh_CN catalogs from the guidebook submodule (single home)#11sanchuanhehe wants to merge 1 commit into
sanchuanhehe wants to merge 1 commit into
Conversation
Translation catalogs are editorial content, so they should live in the editorial repo next to the source they translate. This fixes an earlier oversight where the canonical catalogs were kept here in production while CONTRIBUTING.md/README.md already documented guidebook/locales/ as their home. - conf.py: point locale_dirs at the guidebook submodule's locales/ - remove the duplicate locales/ copy from this repo - docs.yml: run the catalog-freshness check and status report against guidebook/locales (git -C guidebook diff --exit-code) - tools/i18n: default --locale-dir to guidebook/locales Depends on theopensourceway/guidebook#265 (which updates the catalogs in the editorial repo). The submodule pointer here will be moved to that PR's merge commit before this is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Depends on theopensourceway/guidebook#265 — do not merge until that lands. The submodule pointer here references the guidebook branch commit; I'll re-point it to #265's merge commit and take this out of draft once it merges (CI will go green then — until then the submodule commit isn't reachable from
theopensourceway/guidebook).Why
Translation catalogs are editorial content and should live in the editorial repo next to the source they translate. Today they were duplicated: the canonical, maintained set here in
production/locales, and an older copy inguidebook(from guidebook#261) that had drifted and was unused.CONTRIBUTING.md/README.mdalready documentguidebook/locales/as the home — this fixes the earlier oversight where the implementation didn't match.What
conf.py:locale_dirs→guidebook/locales(the submodule)locales/copy from this repodocs.yml: catalog-freshness check + status report now run againstguidebook/locales(git -C guidebook diff --exit-code -- locales)tools/i18n: default--locale-dir→guidebook/localesVerification (local)
guidebook/locales(git -C guidebook diff --exit-codeclean)Part of the i18n infrastructure direction in discussion #260.