Introducing the QueryBuildingMode Enum to improve serialization #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum were introduced in PHP8.1 see https://wiki.php.net/rfc/enumerations#serialization but nothing was said about their serialization with
http_build_query. This resulted on Enum using the same serialization as other object ie relying on the results ofget_object_vars.In PHP8.4 Enum representation was updated to match Enum representation with
json_encode. This introduced a couple of changes:http_build_querycan serialiseBackedEnumusing their value;http_build_querycan not serialiseUnitEnumand will throw aTypeErrorUnitEnumcan not be use as input for the first argument ofhttp_build_querywhich will result also in aTypeError.To allow migrating your code from pre-PHP8.4 this PR introduces an Enum:
And improve
QueryString::composeandQueryString::composeFromValueas well asQueryobject related methods that currently uses onlyhttp_build_query.