fix(media): left-register DK continuous tape margins#3
Merged
Conversation
All DK rolls seat against the same edge of the print head (left-registered), so the small tape-edge offset belongs in leftMarginPins. The continuous family shipped with L/R swapped, parking the printable area off the paper -> blank prints on narrow tapes (reported on DK-22210 / 29mm, QL-800, #2). Swap L/R on continuous entries 257/258/261/262/264/260; 259 and 251 are symmetric. Die-cut entries unaffected. Drop the stale brother_ql attribution comment on DK-11201 (271).
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
mannes
added a commit
that referenced
this pull request
May 30, 2026
Mark QL-800 usb support 'verified' citing report #2, matching the QL-700 entry shape (no quirks; packageVersion; external-reporter note). The device prints fine over USB; the blank was a media-config bug (DK continuous margins stored right-registered), fixed in PR #3, shipped in 0.6.1. Regenerated hardware tables (2->3 verified) and API docs.
mannes
added a commit
that referenced
this pull request
May 30, 2026
* data(QL-800): record usb verification from issue #2 Mark QL-800 usb support 'verified' citing report #2, matching the QL-700 entry shape (no quirks; packageVersion; external-reporter note). The device prints fine over USB; the blank was a media-config bug (DK continuous margins stored right-registered), fixed in PR #3, shipped in 0.6.1. Regenerated hardware tables (2->3 verified) and API docs. * release: 0.6.1 Patch release carrying the DK continuous-tape margin fix (left- registration) and the QL-800 usb verification. core/node/web -> 0.6.1. * chore: format fix --------- Co-authored-by: Mannes Brak <info@mbtech.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 revealed marginPins values to be swapped for continuous labels. Confirmed by checking against values of evenly wide 29mm, bench confirmed, DK-11201.