Conversation
…DL image than vice versa)
…to use the correct image for the .pytest-plain jobs
…ll to the before_script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Docker image, then builds and uses it in CI. The Docker image is based on a GHDL one, and bundles conifer and its requirements into a Python environment. So with the image alone users could get started with most backends, but without the capability to synthesize.
The logic for building and using the image in the CI pipeline might seem a bit convoluted. The thinking behind it is:
latestimage if the commit doesn't change the image contentlatestshould only be published on commits to master branch - in other words only approved changes to the Dockerfile will be published tolatestSo in the CI pipeline that is implemented as:
latestonly for commits tomasterlatestotherwiseThe main unsolved thing is that the tests using
buildrequiring CI4FPGA don't use this conifer Docker image. I don't really see a way to avoid using CI4FPGA, and I still think it's good to use it when only strictly necessary. Note: in order to test the use oflatest, I had to manually tag one image withlatest, since there haven't been any commits of this yet to master branch obviously.I'll add something in the README about how users can get hold of this image once the code content is agreed.