Let ClangCL preset auto-detect the Visual Studio generator#98
Merged
Conversation
|
No base build to compare — fix-clangcl-vs-generator into main |
The hardcoded "Visual Studio 17 2022" generator broke when windows-latest moved to windows-2025, which ships VS 18. Dropping the explicit generator lets CMake pick whatever VS version is installed, matching the behaviour of the MSVC preset.
thetic
force-pushed
the
fix-clangcl-vs-generator
branch
from
July 10, 2026 03:52
b677d0c to
8046049
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-latestnow points towindows-2025, which ships Visual Studio 18 (2025)ClangCLpreset had"generator": "Visual Studio 17 2022"hardcoded, causing CMake to fail with could not find any instance of Visual StudioMSVCpreset never specified a generator and works fine because CMake auto-detects whatever VS version is installedClangCLso it does the same