Custom form element validation and default global validate-on support. - #8
Open
ugurerkan wants to merge 2 commits into
Open
Custom form element validation and default global validate-on support. #8ugurerkan wants to merge 2 commits into
ugurerkan wants to merge 2 commits into
Conversation
ugurerkan
changed the title
|
👍 nice, @thetutlage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 😊
I noticed an issue when working with custom form directives. Validation-schema doesn't recognize them because of input, select, textarea query selection and decided to change query with name attribute selection. Thought this is better and have backward compatibility.
Also, defaultSchema object validate-on property is default watch and angular-validation is have ability to set valid method on configuration. I make changes for get valid method from $validationProvider.