Skip to content

Conversation

@gregorbg
Copy link
Member

@gregorbg gregorbg commented Nov 21, 2025

There were plenty of small but important (in terms of complexity) places throughout Results Validator logic that had a pretty complicated idea about rounds, getting round data, comparing round IDs, etc.

This PR aims to fully clean these spaces up, now that we have stable, mandatory round ID references on results as well as inbox_results. In practice, this means two things:

  • Validations along the lines of "unexpected results for a round which doesn't exist" don't make sense anymore, because every uploaded result has to reference its round.
  • Playing switcheroo with Round Type IDs (which are heavily based on cutoff) is not necessary anymore, because you cannot have the "oh you said this was planned as cutoff but actually everyone made cutoff so it got synced as the 'wrong' round type" case anymore. Again, every uploaded result has to clearly reference its round that must be fully in-sync with the "Edit Events" panel.

@gregorbg gregorbg changed the title Hook inbox_scrambles into Results Validators Clean up rounds handling in Results Validators Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant