Live next competitor page #13044
Live next competitor page #13044
Conversation
next-frontend/src/app/(wca)/competitions/[competitionId]/competitors/page.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <TabCompetitors | ||
| id={competitionId} | ||
| isLive={hasPassed(competitionInfo.start_date)} |
There was a problem hiding this comment.
You should probably also check for the competition end date not having passed as well
There was a problem hiding this comment.
well.. the competitors tab is not shown if the competition end date has passed
There was a problem hiding this comment.
That does not keep anyone from bookmarking a link to this page while it's still visible, and then trying to open it 10 days later
There was a problem hiding this comment.
Why are you introducing this new route as a pure redirect?
Is this an existing page that needs to be implemented to keep deep-link backwards compatibility?
There was a problem hiding this comment.
it is, but just on the wca live side so maybe we don't actually need it
There was a problem hiding this comment.
I would actually argue that we don't. Because the use of stable competition IDs is a new concept, WCA Live used to use integer IDs for that. So we're breaking any and all old links anyways.
2 participants
Basically enables a "live" mode for the competitor table that links to the live results. We should probably add a search bar like in the current wca live page?