Skip to content

Adding alternative tree metrics - #8

Open
ms609 wants to merge 9 commits into
thibautjombart:masterfrom
ms609:master
Open

Adding alternative tree metrics#8
ms609 wants to merge 9 commits into
thibautjombart:masterfrom
ms609:master

Conversation

@ms609

@ms609 ms609 commented Jul 29, 2020

Copy link
Copy Markdown

Hi Michelle, I wonder whether you would be happy to support some tree distance method that I've recently developed to this package?

I have added some tree metrics to treespace.R and documented them.

Cheers,

Martin

@MichelleKendall

Copy link
Copy Markdown
Collaborator

Hi Martin,

Yes absolutely - the more the merrier! I will take a proper look asap. Right now there's a check failing but perhaps that's something you're already aware of / addressing?

Thanks,

Michelle

@ms609

ms609 commented Jul 31, 2020

Copy link
Copy Markdown
Author

Great, thanks Michelle!

I've fixed the error – there had been a one-off connectivity issue with the most recent check that made me overlook the actual problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants