feat: Add offset option for scaling measurement values#52
Merged
C8Y-Mario merged 5 commits intothin-edge:mainfrom Feb 23, 2026
Merged
feat: Add offset option for scaling measurement values#52C8Y-Mario merged 5 commits intothin-edge:mainfrom
C8Y-Mario merged 5 commits intothin-edge:mainfrom
Conversation
| @@ -1,5 +1,6 @@ | |||
| #!/usr/bin/env python3 | |||
| """Cumulocity IoT c8y_Coils operation handler""" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Ideally formatting commits should be done in a different PR if the PR is including a new function (e.g. commit 0ed05c6), otherwise it makes it harder to review as there is some additional "noise" for unrelated topics. But we can keep this commit for now in the PR, but it would be helpful for the future.
Robot Results
Passed Tests
|
reubenmiller
approved these changes
Feb 23, 2026
Contributor
reubenmiller
left a comment
There was a problem hiding this comment.
Thanks for the PR @wilbersl, only one minor comment for the future, but overall a very nice addition
Contributor
Author
|
Always happy to add stuff ;) ! @reubenmiller Thanks for the comment, I'll try to do as you told. As I mostly work alone, I'm not really trained in proper team workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additive scaling option (
offset) to register definitionDescription
This PR introduces an additional scaling option called
offsetto the register definition.The
offsetis applied after all existing multiplication-based scaling factors (multiplier,divisor,decimalShiftRight) have been processed.This enables linear value transformations of the form:
Motivation
Some registers cannot be represented correctly using multiplication-only scaling.
Typical use cases include:
-40°C)Adding
offsetallows these cases to be modeled cleanly while keeping the existing scaling model intact.Implementation Details
offsetfield to the register definitionoffsetafter all existing scaling operations0Backward Compatibility
offsetbehave exactly as beforeExample