Skip to content

fix(parser): fail loudly when the OssInsight ranking is unavailable #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sigmanor merged 2 commits into from
Sep 8, 2026
Merged

fix(parser): fail loudly when the OssInsight ranking is unavailable #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5fa3e7
fix(parser): fail loudly when the OssInsight ranking is unavailable
sigmanor Sep 8, 2026
4d6932a
fix(parser): let a narrow OssInsight query come back empty
sigmanor Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions parser/ossinsight.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ type OssInsightResponse struct {
Forks string `json:"forks"`
} `json:"rows"`
} `json:"data"`
DataQuality struct {
Status string `json:"status"`
Metric string `json:"metric"`
UnavailableSince string `json:"unavailable_since"`
Reason string `json:"reason"`
} `json:"data_quality"`
}

func GetTrendingReposFromOssInsight(maxRepos int, period, language string) ([]Repository, error) {
Expand Down Expand Up @@ -87,6 +93,19 @@ func GetTrendingReposFromOssInsight(maxRepos int, period, language string) ([]Re
return nil, fmt.Errorf("failed to decode OssInsight response: %v", err)
}

// OssInsight answers with HTTP 200 and no rows when the ranking it is asked
// for cannot be computed, so the payload has to be checked explicitly.
if q := apiRes.DataQuality; q.Status != "" && q.Status != "ok" {
return nil, fmt.Errorf("OssInsight metric %q is %s since %s: %s", q.Metric, q.Status, q.UnavailableSince, q.Reason)
}
// A narrow language filter can legitimately match nothing, the same way the
// GitHub trending page can come back empty, so only an unfiltered query that
// yields nothing is treated as a failure. This keeps the empty-payload guard
// useful even if the data_quality block ever disappears from the response.
if len(apiRes.Data.Rows) == 0 && (language == "" || language == "All") {
return nil, fmt.Errorf("OssInsight returned no trending repositories for period %q", period)
}

var allRepos []Repository
for _, row := range apiRes.Data.Rows {
if !isEnglishText(row.Description) {
Expand Down