fix(dashboard): restore sort/filter in the state initialiser, not an effect (agent-os-14b)

[thinkbig1979]

Unblocks Dependabot's npm group PR #22, which fails frontend CI at Lint.

What is actually wrong

The code #22 trips over is pre-existing and untouched by that PR. What changed is the linter: eslint-plugin-react-hooks moves ^7.0.1 → ^7.1.1 in that group, and 7.1.x enforces react-hooks/set-state-in-effect.

DashboardPage.tsx
  77:20  error  Calling setState synchronously within an effect can trigger cascading renders
                react-hooks/set-state-in-effect

This is not the pnpm minimumReleaseAge interaction — that was verified working on the same run (Install dependencies → success).

Left alone, every weekly npm group PR carries the same failure and none get merged, which defeats the point of adding Dependabot.

Fix

The rule points at something real, so this fixes the effect rather than disabling the rule. Reading localStorage in the useState initialiser gives the same result in one render instead of two — the mount effect rendered the defaults, then re-rendered with the stored values.

Verification

Checked against #22's actual dependency set, not main's, since main's eslint does not yet have the rule:

git worktree add <tmp> pr22 && pnpm install --frozen-lockfile
node ./node_modules/eslint/bin/eslint.js .

	result
before this change	1 error, exit 1 — the error above, and the only one in the tree
after this change	0 errors, exit 0

Tests

Adds the first coverage of the localStorage-restore contract, which had none.

Being straight about what they prove: these two tests pin the restored values the page hands to StacksTab. They do not distinguish this implementation from the effect-based one, and the comment says so. StacksTab is gated behind the loading state, so it first renders after effects have already flushed and both versions look identical from the DOM — confirmed by reverting the fix with the tests in place, where they still passed. The guard against a relapse is the lint rule itself.

Gates

• eslint → exit 0
• tsc -b → no errors
• vitest --run → 823 passed in 80 files (821 baseline + the 2 added here)
• pnpm build → ok

Closes agent-os-14b.

[github-actions]

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit b632872.}