Harden @ottabase/ottasearch query parsing and remove partial reindex limits#133
Draft
Harden @ottabase/ottasearch query parsing and remove partial reindex limits#133
@ottabase/ottasearch query parsing and remove partial reindex limits#133Conversation
Co-authored-by: thinkdj <688055+thinkdj@users.noreply.github.com>
Co-authored-by: thinkdj <688055+thinkdj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement Ottabase Search with D1 FTS and vectorization
Implement in-house Feb 28, 2026
@ottabase/ottasearch (D1 FTS + optional Vectorize), add admin search management UI, and wire global spotlight search
Co-authored-by: thinkdj <688055+thinkdj@users.noreply.github.com>
Copilot
AI
changed the title
Implement in-house
Harden Feb 28, 2026
@ottabase/ottasearch (D1 FTS + optional Vectorize), add admin search management UI, and wire global spotlight search@ottabase/ottasearch query parsing and remove partial reindex limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two valid issues in the new in-house search stack: fragile FTS query handling for malformed user input, and incomplete indexing caused by a hard 200-row reindex cap.
It also tightens helper coverage for query normalization edge cases.
Problem summary
FTS MATCHaccepted raw user input, which could produce malformed queries (***, unbalanced symbols) and unstable search behavior.limit: 200), leaving larger models partially indexed.Changes
normalizeFtsQuery(query)inpackages/ottasearch/src/search.ts.term*) joined withOR.packages/ottasearch/src/index.ts.worker/routes/ottasearch.tsnow uses normalized query and returns empty result sets when no valid terms remain.ModelClass.all({ limit: 200 })with paged reads (limit + offset) until exhaustion.packages/ottasearch/src/__tests__/search.test.tswith normalization edge cases:Illustrative snippet
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.