33. Keyboard shortcuts for moves enhancement#133
Open
vlaxcs wants to merge 3 commits intothomas-mauran:mainfrom
Open
33. Keyboard shortcuts for moves enhancement#133vlaxcs wants to merge 3 commits intothomas-mauran:mainfrom
vlaxcs wants to merge 3 commits intothomas-mauran:mainfrom
Conversation
Owner
|
Was this done @vlaxcs ? |
cf5db72 to
c75428c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard shortcuts for moves enhancement
Do not merge in this state.
This is not the final version, so i just need a review and some guiding from here.
Description
Any gameboard cell could be selected now using key-combos (A8 or 8A will work).
Initially, the cursor will be set on the column corresponding to the given letter / on the row corresponding to the given digit, no matter the order of presses.
Currently, i implemented it only for white view.
As we know, we have columns marked from A to H, but the C/c cases are closing the app.
So, cell movements requires lower letters (a to h), and close-app feature will work only with Ctrl+C (uppercase).
Fixes # (33) Keyboard shortcuts for moves enhancement
How Has This Been Tested?
I tried to select every cell on gameboard (with select/unselected pieces).
Checklist: