Support Ring-MQTT activity timestamps - #3
Open
thomasgregg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Ring View’s existing last-activity display work with Ring-MQTT Ding and motion binary sensors while preserving the same card and viewer layout.
What changed
binary_sensor.*in the Last activity selector.lastDingTime,lastMotionTime,lastDing, andlastMotion.Edge cases covered
last_changedandlast_updated, which are intentionally not treated as activity time.The visual editor schema and card design do not vary by provider.
Verification
npm test -- --run— 163 tests passed.npm run check— passed.npm run build— passed.npm run test:browser— 112 tests passed on phone and desktop.git diff --check— passed.Stack
PR 2 of 5. Base:
codex/ring-mqtt-parity-foundation.