Play Ring-MQTT recorded events - #5
Open
thomasgregg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Ring-MQTT Event Select as a first-class recording source behind Ring View’s existing Last recording tab.
What changed
recording_entityselect either a camera or Ring-MQTT Event Select.recordingUrlwhile retaining official Ring camera playback.Recording Not FoundandTranscoding in Progresssentinels as non-playable media.Edge cases covered
The Event Select’s current option—such as Ding 1, Motion 1, or a transcoded variant—determines which recording is shown. The refresh path is event-driven and does not poll.
Verification
npm test -- --run— 185 tests passed.npm run check— passed.npm run build— passed.npm run test:browser— 114 tests passed on phone and desktop.git diff --check— passed.Stack
PR 4 of 5. Base:
codex/ring-mqtt-fresh-snapshots.