Skip to content

Expose public API in dir(impulso) via __dir__#28

Open
niall-stack wants to merge 1 commit intothomaspinder:mainfrom
niall-stack:fix-25-dir-public-api
Open

Expose public API in dir(impulso) via __dir__#28
niall-stack wants to merge 1 commit intothomaspinder:mainfrom
niall-stack:fix-25-dir-public-api

Conversation

@niall-stack
Copy link
Copy Markdown

Summary\nAdds a module-level dir in src/impulso/init.py so interactive discovery tools and IDE completion include all public API names from all.\n\nAlso adds a focused test in ests/test_public_api.py to ensure each all symbol appears in dir(impulso).\n\n## Why\nFixes #25 (getattr does not update dir).\n\n## Validation\nI added/updated tests for this behavior.\n\nNote: I could not run pytest locally in this environment because no Python runtime is installed on host (py -3.11 reported no suitable runtime).

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.9%. Comparing base (cfe95cc) to head (c54aa67).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (88.9%) is below the target coverage (90.0%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #28   +/-   ##
=====================================
  Coverage   88.9%   88.9%           
=====================================
  Files         16      16           
  Lines        651     653    +2     
  Branches      83      83           
=====================================
+ Hits         579     581    +2     
  Misses        53      53           
  Partials      19      19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thomaspinder
Copy link
Copy Markdown
Owner

Thanks for opening this PR. It looks like the PR branch is stale, so I think you'll just need to rebase the PR. Once rebased, you'll need to add all entities into __all__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants