Fix Cholesky structural_shock_matrix dim/coord ordering#29
Open
niall-stack wants to merge 1 commit intothomaspinder:mainfrom
Open
Fix Cholesky structural_shock_matrix dim/coord ordering#29niall-stack wants to merge 1 commit intothomaspinder:mainfrom
niall-stack wants to merge 1 commit intothomaspinder:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (88.9%) is below the target coverage (90.0%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=====================================
Coverage 88.9% 88.9%
=====================================
Files 16 16
Lines 651 651
Branches 83 83
=====================================
Hits 579 579
Misses 53 53
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for opening this PR. It looks like the PR branch is stale, so I think you'll just need to rebase the PR. Once this is done, I think we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nFixes the Cholesky identification output to use the same dim/coord ordering as the sign-restriction path (
esponse, shock).\n\n### Changes\n- In Cholesky.identify, changed structural_shock_matrix dims from:\n - (chain, draw, shock, response)\n to:\n - (chain, draw, response, shock)\n- Updated coord mapping accordingly.\n- Added a regression assertion in ests/test_identification.py to lock the expected dim + coord order.\n\n## Why\nIssue #26 reports that Cholesky xarray labels are transposed relative to SignRestriction, which can cause downstream confusion/misalignment.\n\n## Validation\nAdded targeted test assertions for dims and coords.\n\nNote: I couldn’t execute pytest in this environment because no Python runtime is installed on host (py -3.11 reports no suitable runtime).