Repository navigation
deploy.py: a failed build stops before the upload - #6
Merged
Merged
Conversation
The build and upload ran without check=True, so a failed build went on to upload whatever stale files were in dist/. Both now raise on failure (as dacc's deploy.py already does). deploy.py is a manual script outside the package, so nothing is released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint review of #4 (deploy.py guarded behind
__main__). The guard is right. One gap remained: the build and upload ran withoutcheck=True, so a failed build went on to upload whatever stale files were indist/. Both now raise on failure, asi2mint/dacc'sdeploy.pyalready does. A test pins that a failed build uploads nothing.deploy.pysits outside the package, so this merge should not release: the squash commit carries[skip ci].Local: full suite green. Hosted checks: see below.
🤖 Generated with Claude Code