Repository navigation
Time out a stuck feed refresh and report cancelled runs - #137
Merged
Merged
Conversation
The refresh job had no timeout-minutes, so a stuck run held the runner for the 360 minute default. A run killed by a timeout ends cancelled, and the failure report ran only on failure(), so it opened no issue. The job now times out after 30 minutes (recent runs take 0 to 2), and the report step runs on failure() || cancelled() and records the job status. A probe workflow on a temporary branch confirmed that a job timeout ends the job cancelled and still runs a cancelled() step, with job.status = cancelled. A manual cancel now also reports; that is rare and visible. Fixes #133. Implemented by Claude; verified by a GitHub Actions probe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133.
Summary
refreshjob getstimeout-minutes: 30. Recent runs take 0 to 2 minutes.failure() || cancelled(), so a timed-out run opens or updates the "Feed refresh automation failed" issue. The issue body now includes the job status.Verification
timeout-minutes: 1and a 150 s sleep. The job endedcancelled, and thefailure() || cancelled()step ran and printedstatus=cancelled. I deleted the branch and the run afterward.npm testpasses locally.A manual cancel now also reports. That is rare, and the issue says
Job status: cancelled.🤖 Generated with Claude Code