Skip to content

Typo adjustments, black formatting, drop Python 3.9, support Python 3.13#334

Merged
thouska merged 8 commits intothouska:masterfrom
Zeitsperre:typo-adjustments
May 28, 2025
Merged

Typo adjustments, black formatting, drop Python 3.9, support Python 3.13#334
thouska merged 8 commits intothouska:masterfrom
Zeitsperre:typo-adjustments

Conversation

@Zeitsperre
Copy link
Copy Markdown
Contributor

@Zeitsperre Zeitsperre commented May 27, 2025

Hi there,

I couldn't help but notice a few typos when running spotpy and decided to do a very quick code cleanup. Changes in this PR are:

  • Correcting spelling/grammar errors
  • Configuring the package metadata to reflect the lowest-supported Python (3.9+)
  • Added build tests for Python3.9 in GitHub Workflow
  • Configuring black for Python3.9+
  • Running python -m black over the code base
  • Adding black to the code linting checks in GitHub Workflow
  • Dropped support for Python3.9, extended support to Python3.13

Let me know if there are any changes you'd like me to make.

Best,

@coveralls
Copy link
Copy Markdown

coveralls commented May 27, 2025

Pull Request Test Coverage Report for Build 15283517039

Details

  • 24 of 99 (24.24%) changed or added relevant lines in 15 files are covered.
  • 14 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.006%) to 67.799%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/spotpy/algorithms/padds.py 1 2 50.0%
src/spotpy/examples/spot_setup_hymod_exe.py 0 1 0.0%
src/spotpy/likelihoods.py 0 3 0.0%
src/spotpy/analyser.py 2 16 12.5%
src/spotpy/algorithms/efast.py 8 64 12.5%
Files with Coverage Reduction New Missed Lines %
src/spotpy/algorithms/abc.py 1 84.21%
src/spotpy/algorithms/padds.py 1 12.61%
src/spotpy/analyser.py 1 83.41%
src/spotpy/examples/spot_setup_ackley.py 1 0.0%
src/spotpy/examples/spot_setup_hymod_python_pareto.py 1 0.0%
src/spotpy/examples/spot_setup_standardnormal.py 1 0.0%
src/spotpy/examples/spot_setup_hymod_unix.py 2 0.0%
src/spotpy/algorithms/efast.py 6 16.67%
Totals Coverage Status
Change from base Build 13455084357: 0.006%
Covered Lines: 3752
Relevant Lines: 5534

💛 - Coveralls

@Zeitsperre Zeitsperre changed the title Typo adjustments, black formatting Typo adjustments, black formatting, drop Python 3.9, support Python 3.13 May 27, 2025
@thouska
Copy link
Copy Markdown
Owner

thouska commented May 28, 2025

Hi @Zeitsperre,
wow, thank you so much for your contribution to spotpy!
I checked it out and have to say it looks excellent! Thank you so much!

@thouska thouska merged commit 5b094bf into thouska:master May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants